On Mon, Sep 22, 2014 at 11:43:35AM -0400, Jason Merrill wrote: > On 09/22/2014 11:26 AM, Jakub Jelinek wrote: > >On Mon, Sep 22, 2014 at 11:21:14AM -0400, Jason Merrill wrote: > >>If I say 'rgt dg.exp=var-templ1.C' the actual test results are lost in the > >>explosion of shell verbosity. Could we add some '@'s to more of the rules, > >>perhaps? > > > >I've been considering that too, but not sure what info people find valuable > >and what they don't. > > I don't see much information in the ~128 repetitions of the check-parallel > rules with different numbers; the actual runtest command is the same in all > of them. Adding @ to all of the commands of the check-parallel-% rule makes > things much better for me:
LGTM (though, supposedly we want similar change in libstdc++-v3/testsuite/Makefile.am). Or, if people would really like to see the commands, we could print them just once, using e.g. -$(if $(check_p_subno),@)(rootme= ... (then e.g. check-parallel-gcc goal would print the command, but check-parallel-gcc-1 or check-parallel-gcc-112 would not). > --- a/gcc/Makefile.in > +++ b/gcc/Makefile.in > @@ -3674,10 +3674,10 @@ $(lang_checks_parallelized): check-% : site.exp > fi > > check-parallel-% : site.exp > - -test -d plugin || mkdir plugin > - -test -d $(TESTSUITEDIR) || mkdir $(TESTSUITEDIR) > - test -d $(TESTSUITEDIR)/$(check_p_subdir) || mkdir > $(TESTSUITEDIR)/$(check_p_subdir) > - -(rootme=`${PWD_COMMAND}`; export rootme; \ > + -@test -d plugin || mkdir plugin > + -@test -d $(TESTSUITEDIR) || mkdir $(TESTSUITEDIR) > + @test -d $(TESTSUITEDIR)/$(check_p_subdir) || mkdir > $(TESTSUITEDIR)/$(check_p_subdir) > + -@(rootme=`${PWD_COMMAND}`; export rootme; \ > srcdir=`cd ${srcdir}; ${PWD_COMMAND}` ; export srcdir ; \ > if [ -n "$(check_p_subno)" ] \ > && [ -n "$$GCC_RUNTEST_PARALLELIZE_DIR" ] \ Jakub