On Tue, Oct 7, 2014 at 3:45 AM, Dominik Vogt <v...@linux.vnet.ibm.com> wrote: > > The only points in that patch are that on one hand - as far as I > know - the Abi does not guarantee that section symbols are either > zero or not relocated, even if that may be the case in reality. > And on the other hand, if that code is ever modified to handle > non-section symbols, it's not obvious that you not only need to > remove the test for the symbol type but also modify the > calculations below. So, apply the patch or drop it as you like, > but in any case, at least a comment in the code would improve > maintainability.
I proposed this patch for the master repository: https://codereview.appspot.com/155190043 Ian
