Re: [PATCH] Don't expand string/memory builtins if ASan is enabled.

[Yury Gribov]

On 10/17/2014 04:24 PM, Jakub Jelinek wrote:
+/* Returns TRUE if given FCODE corresponds to string or memory builtin 
function.
+ */
+
+static inline bool
+is_memory_builtin (enum built_in_function fcode)
+{
+  return fcode <= BUILT_IN_STRSTR && fcode >= BUILT_IN_BCMP;

This is too fragile and ugly.
IMHO you should list (supposedly not in a special inline, but directly
where you use it) in a switch all the builtins you don't want to expand.

We already do this for BUILT_IN_ASAN_REPORT_LOAD1 ... 
BUILT_IN_ASAN_STOREN but I agree that this one is more ugly.

-Y