On Fri, Oct 17, 2014 at 3:36 PM, Martin Liška <[email protected]> wrote:
> Hello.
>
> Following patch fixes PR63569.
>
> Bootstrap executed on ppc64-linux and no regression seen on x86_64-pc-linux.
> Ready for trunk?
Um. As suggested in the bugreport I replied to please work on splitting
out general operand vs. memory operand compare.
+bool
+func_checker::compare_volatility (tree t1, tree t2)
+{
+ if (t1 && t2)
+ return TREE_THIS_VOLATILE (t1) == TREE_THIS_VOLATILE (t2);
+
+ return !(t1 || t2);
The last check looks unrelated to me. Either you want to do this
quick check inline for all operand compares or defer to compare_operand?
Btw, I think the volatility check would be better placed in the memory
operand compare function when comparing handled-components and
decls.
Richard.
> Thank you,
> Martin
