Re: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

[Jeff Law]

On 10/31/14 09:34, Zamyatin, Igor wrote:
Hi!
Following patch (moving initialization of pic_offset_table_rtx
earlier) fixes failures for asan tests on 32 bits in PIC mode mentioned
here - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63534#c48


Bootstrapped/regtested on x86_64, i686

Is it ok for trunk?

ChangeLog:

2014-10-30  Igor Zamyatin  <igor.zamya...@intel.com>

        * function.c (assign_parms): Move init of pic_offset_table_rtx
        from here to...
        * cfgexpand.c (expand_used_vars): ...here.
The patch is probably fine.  However, it would be good to have the 
analysis why you want to move initialization of the PIC register earlier.

You should also reference the PR in the ChangeLog like this:

        PR target/63634

So get the analysis posted, and I'll likely approve after reviewing the 
background info.

Thanks,
Jeff