On Fri, Nov 7, 2014 at 12:51 AM, Dominik Vogt <v...@linux.vnet.ibm.com> wrote:
> On Thu, Nov 06, 2014 at 09:06:18AM -0800, Ian Taylor wrote:
>> On Thu, Nov 6, 2014 at 4:04 AM, Dominik Vogt <v...@linux.vnet.ibm.com> wrote:
>> > On Tue, Nov 04, 2014 at 08:16:51PM -0800, Ian Taylor wrote:
>> >> The way to do it is not by
>> >> copying the test.  If the test needs to be customized, add additional
>> >> files that use // +build lines to pick which files is built.  Move
>> >> them into a directory, like method4.go or other tests that use
>> >> "rundir".
>> >
>> > Currently go-test.exp does not look at the "build" lines of the
>> > files in subdirectories.  Before I add that to the gcc testsuite
>> > start adding that, is it certain that the golang testsuite will be
>> > able to understand that and compile only the requested files?
>>
>> Hmmm, that is a good point.  The testsuite doesn't use the go command
>> to build the files in subdirectories, so it won't honor the +build
>> lines.  I didn't think of that.  Sorry for pointing you in the wrong
>> direction.
>
> That's no problem, I can enhance go-test.exp in Gcc.  The question
> is if test cases extended in such a way would run in the master Go
> repository too.  Are the tests there run with the Go tool?

I'm sorry, I wasn't clear.  The test cases will not work in the master
Go repository.  When I said "the testsuite doesn't use go command" I
was referring to the master testsuite.  Sorry for the confusion.

Ian

Reply via email to