Hi Jack,
comments below apply also to the patch for PR63699
On 7 Nov 2014, at 17:13, Jack Howarth wrote:
> The attached revised patch eliminates the compilation error...
>
> error: use of undeclared
> identifier 'do_not_use_toupper_with_safe_ctype'
>
> on x86_64-apple-darwin14 when bootstrapping using the Clang 6.0
> compiler by moving the include for <strings> earlier.
> Okay for gcc trunk?
> Jack
> <PR63750_v3.patch>
Since you have two instances of this (and given that the other required headers
are included in system.h)
ISTM, that the right place for this (and the fix for PR63699) is in system.h
with appropriate guards for cplusplus and an explanation of why the fix is
needed.
Need to make sure we're not just burying some other problem, right?
0.02GBP as always
Iain
2014-10-07 Jack Howarth <howarth.at....@gmail.com>
PR other/63750
* gcc/ipa-chkp.c: Include string earlier.
In any event, if the existing patch is preferred by the maintainers, please
make this ^ something like
"Include <string> before system.h"
to give to poor reader some idea of what the change was about ;)
