It is true that we typically don't care about old kernels. Those who care about older kernels are welcome to submit patches upstream -- I don't think we ever rejected a reasonable patch that does not significantly increase our maintenance headache. Using -std=gnu++ for building these sources in GCC is potentially leading to large delays in the merge process: imagine that some of the code upstream gets incompatible with -std=gnu++ for whatever reason.
--kcc On Fri, Nov 14, 2014 at 11:35 AM, Andrew Pinski <pins...@gmail.com> wrote: > On Fri, Nov 14, 2014 at 11:29 AM, Konstantin Serebryany > <konstantin.s.serebry...@gmail.com> wrote: >> +gcc-patches >> >> On Fri, Nov 14, 2014 at 11:26 AM, Konstantin Serebryany >> <konstantin.s.serebry...@gmail.com> wrote: >>> I am opposed to this change. >>> Upstream code builds with -std=c++11. >>> Building this code here with another set of options is a time bomb. > > Then how are you handling older kernel headers? I guess you guys > don't care that much about older kernels then. > See https://gcc.gnu.org/ml/gcc-patches/2014-11/msg01735.html for more > details and https://gcc.gnu.org/ml/gcc-patches/2014-11/msg01769.html > for the approval. > > Thanks, > Andrew Pinski > > >>> >>> On Fri, Nov 14, 2014 at 6:23 AM, <u...@gcc.gnu.org> wrote: >>>> Author: uros >>>> Date: Fri Nov 14 14:23:51 2014 >>>> New Revision: 217562 >>>> >>>> URL: https://gcc.gnu.org/viewcvs?rev=217562&root=gcc&view=rev >>>> Log: >>>> * sanitizer_common/Makefile.am (AM_CXXFLAGS): Use -std=gnu++11. >>>> * asan/Makefile.am (AM_CXXFLAGS): Ditto. >>>> * lsan/Makefile.am (AM_CXXFLAGS): Ditto. >>>> * interception/Makefile.am (AM_CXXFLAGS): Ditto. >>>> * tsan/Makefile.am (AM_CXXFLAGS): Ditto. >>>> * libbacktrace/Makefile.am (AM_CXXFLAGS): Ditto. >>>> * ubsan/Makefile.am (AM_CXXFLAGS): Ditto. >>>> * sanitizer_common/Makefile.in: Regenerate. >>>> * asan/Makefile.in: Ditto. >>>> * lsan/Makefile.in: Ditto. >>>> * interception/Makefile.in: Ditto. >>>> * tsan/Makefile.in: Ditto. >>>> * libbacktrace/Makefile.in: Ditto. >>>> * ubsan/Makefile.in: Ditto. >>>> >>>> >>>> Modified: >>>> trunk/libsanitizer/ChangeLog >>>> trunk/libsanitizer/asan/Makefile.am >>>> trunk/libsanitizer/asan/Makefile.in >>>> trunk/libsanitizer/interception/Makefile.am >>>> trunk/libsanitizer/interception/Makefile.in >>>> trunk/libsanitizer/libbacktrace/Makefile.am >>>> trunk/libsanitizer/libbacktrace/Makefile.in >>>> trunk/libsanitizer/lsan/Makefile.am >>>> trunk/libsanitizer/lsan/Makefile.in >>>> trunk/libsanitizer/sanitizer_common/Makefile.am >>>> trunk/libsanitizer/sanitizer_common/Makefile.in >>>> trunk/libsanitizer/tsan/Makefile.am >>>> trunk/libsanitizer/tsan/Makefile.in >>>> trunk/libsanitizer/ubsan/Makefile.am >>>> trunk/libsanitizer/ubsan/Makefile.in >>>>
