On Wed, Oct 29, 2014 at 10:20 AM, Jiong Wang <jiong.w...@arm.com> wrote:
> On 26/08/14 13:36, Richard Earnshaw wrote:
>
>> On 29/07/14 15:49, Jiong Wang wrote:
>>>
>>> test done
>>> ===
>>> no regression on the full toolchain test on arm-none-eabi.
>>>
>>>
>>> ok to install?
>>
>> Hmm, I think this is wrong for DF mode.  The principle the patch works
>> on is by tying the output to the value containing the sign bit, and then
>> copying the rest of the other value into that value.  However, for DF
>> mode it only copies 31 of the 63 bits needed; the least significant 32
>> bits of the mantissa are not copied over.
>>
>> R.
>
>
> updated the patch. fixed the DF mode bug.
>
> no regression on arm-none-eabi multi-lib test.
>
> ok to trunk?
>
> gcc/
>   * config/arm/arm.md (copysignsf3): New define_expand for SImode.

New pattern.

>   (copysigndf3): New define_expand for DImode.

Likewise.

Ok for trunk if no regressions.

Sorry about the slow review.

Ramana


>
> gcc/testsuite/
>   * gcc.target/arm/copysign_softfloat_1.c: New copysign/copysignf testcase
> for soft-float.

Reply via email to