On Thu, Dec 4, 2014 at 4:04 AM, Jakub Jelinek <ja...@redhat.com> wrote: > On Thu, Dec 04, 2014 at 04:00:27AM -0800, H.J. Lu wrote: >> >> Can you add a few testcases? >> > >> > Isn't it already covered by gcc.dg/torture/vshuf* ? >> > >> >> I didn't see them fail on my machines today. > > Those are executable testcases, those better should not fail. > The patch just improved code generation and the testcases test > if the improved code generation works well. > Did you mean some scan-assembler test that verifies the better code > generation? Guess it is possible, though fragile.
Well, we will never be sure that the better code is really generated unless we visually exam the assembly code. Any changes in the future may disable the better code generation and we won't notice until much later. -- H.J.
