> > On Mon, Dec 8, 2014 at 11:57 AM, Bernd Edlinger > > <bernd.edlin...@hotmail.de> wrote: > > > > > > > > >> > > >> Hello, > > >> > > >> > > >> this surprisingly simple patch fixes PR ipa/64049. The root cause seems > > >> to be > > >> that in this test case we try to devirtualize a method call on a return > > >> value. > > >> > > >> > > >> Boot-Strapped and regression-tested on X86_64-linux-gnu. > > >> OK for trunk? > > > > I think positive tests, in this case TREE_CODE (...) == VAR_DECL > > are better. > > > > Ok with that change. > > The test there assumes that only values with well defined default value are > parm decls, > so in cases we see a call on default value of other kind of decl, we could > turn it > to undefined call. > > In what cases has RESULT_DECL sane initial value? We should at least drop a > comment here.
I assume those are DECL_BY_REFERENCE return values. Then we probably want TREE_CODE (...) == VAR_DECL || (TREE_CODE (...) == RESULT_DECL && !DECL_BY_REFERENCE (...))? Honza > > Honza > > > > Thanks, > > Richard. > > > > >> > > >> Thanks > > >> Bernd. > > >> > > > > > > Again with changelog. Sorry. > > >
