On Wed, Dec 10, 2014 at 6:16 AM, Chung-Ju Wu <jasonw...@gmail.com> wrote: > 2014-12-09 21:16 GMT+08:00 Richard Biener <richard.guent...@gmail.com>: >> On Tue, Dec 9, 2014 at 6:36 AM, Chung-Ju Wu <jasonw...@gmail.com> wrote: >>> Hi, all, >>> >>> In the discussion thread last year: >>> https://gcc.gnu.org/ml/gcc-patches/2013-05/msg01334.html >>> >>> I extended the script ./contrib/download_prerequisites so that it can >>> download isl and cloog packages for graphite loop optimizations. >>> The patch was proposed to use GRAPHITE_LOOP_OPT=no by default. >>> However, the change I committed into trunk is setting GRAPHITE_LOOP_OPT=yes: >>> https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=199297 >>> >>> I am sorry about my carelessness and I would like to propose a new patch >>> to fix it. The plaintext ChangeLog and patch are as follow: >> >> I'd say keep it as =yes (now that we only need ISL) and adjust the comment >> instead. >> >> Richard. >> > > Thanks for the suggestion. > The followings are proposed patch to adjust comment: > > Index: contrib/ChangeLog > =================================================================== > --- contrib/ChangeLog (revision 218558) > +++ contrib/ChangeLog (working copy) > @@ -1,3 +1,7 @@ > +2014-12-10 Chung-Ju Wu <jasonw...@gmail.com> > + > + * download_prerequisites: Modify the comment for GRAPHITE_LOOP_OPT. > + > 2014-12-09 Laurynas Biveinis <laurynas.bivei...@gmail.com> > Yury Gribov <y.gri...@samsung.com> > > > Index: contrib/download_prerequisites > =================================================================== > --- contrib/download_prerequisites (revision 218558) > +++ contrib/download_prerequisites (working copy) > @@ -19,9 +19,9 @@ > # You should have received a copy of the GNU General Public License > # along with this program. If not, see http://www.gnu.org/licenses/. > > -# If you want to build GCC with the Graphite loop optimizations, > -# set GRAPHITE_LOOP_OPT=yes to download optional prerequisties > -# ISL Library and CLooG. > +# If you want to disable Graphite loop optimizations while building GCC, > +# DO NOT set GRAPHITE_LOOP_OPT as yes so that the ISL package will not > +# be downloaded. > GRAPHITE_LOOP_OPT=yes > > > Is this OK for trunk?
Ok. Thanks, Richard. > > Best regards, > jasonwucj
