Hi Mark! On 2022-01-29T21:20:45+0100, Mark Wielaard <m...@klomp.org> wrote: > On Tue, Jan 25, 2022 at 11:42:41PM +0100, Mark Wielaard wrote: >> I added a filesIsImportant filter to the buildbot gccrs scheduler: >> >> gccrs_files = ["gcc/rust/", "gcc/testsuite/rust/", "gcc/config/.*/*-rust.c"]
Is that last one correct, or should that be 'gcc/config/*/*-rust.c' (glob) or 'gcc/config/.*/.*-rust\.c' (regexp)? After my recent GCC/Rust commit 5691503f11fb6bc5acd8be1e43faa0c5898c4b14 'GCC/Rust pieces of GCC upstream "Mass rename of C++ .c files to .cc suffix"', please change the last one to '.cc' suffix. >> def gccrsImportant(change): >> for file in change.files: >> for pattern in gccrs_files: >> match = re.match(pattern, file) >> if match: >> return True >> return False Ah, so regexp. ;-) >> I think that should make sure that in the future any commits that >> aren't part of the gccrs frontend won't trigger a build. > > This seems to work as expected and has the additional benefit of > skipping those "merge" commits by bors since those don't actually > change any files. That sounds useful, yes. Maybe include 'gcc/DATESTAMP' in 'gccrs_files', so that we also build after merges from upstream (assuming that they span more than a day/do change that file)? Grüße Thomas > Under https://builder.wildebeest.org/buildbot/#/changes you can see > the "builds" for each change (some will now be empty if they didn't > touch any gccrs files). > > Cheers, > > Mark ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
