> -----Original Message----- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Wednesday, October 30, 2013 1:04 PM > To: Gerald Pfeifer; Iyer, Balaji V; gcc@gcc.gnu.org > Subject: Re: libcilkrts portability > > On 10/29/13 16:56, Gerald Pfeifer wrote: > > Hi Balaji, > > > > On Wed, 23 Oct 2013, Iyer, Balaji V wrote: > >> Is there anything you were thinking about that I missed? > > > > the question was in a different context, but making the code a bit > > more portable would be good. > > > > Right now FreeBSD bootstrap is broken due to the following in > > runtime/config/x86/cilk-abi-vla.c (and others): > > > > #include <assert.h> > > #include <stdlib.h> > > #include <stdint.h> > > #ifdef _WIN32 > > # define alloca _alloca > > # define INLINE static __inline > > # pragma warning(disable:1025) // Don't whine about zero extending > > result > of unary operation > > #else > > # include <alloca.h> > > # define INLINE static inline > > #endif > > > > I'm running out of time on my end, but a bit of autoconf-igury and > > > > # ifdef HAVE_ALLOC_H > > # include <alloca.h> > > # endif > > > > should heal this. > > > > ( http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58918 ) > Agreed. Note I assigned 58918 to Balaji :-) >
...I am on it. > jeff