Hi Tamas, On Sun, 06. Oct 2013 at 22:21:52 +0200, Tamas Szekeres wrote: > The commit you're referring to, doesn't seem contain the handling of the > bExactMatch parameter at the driver. At the moment I consider this a bit > redundant if calling OGRLayer::FindFieldIndex with bExactMatch = TRUE does > the same as OGRLayer::GetFieldIndex. In this regard I'd be in favour of using > the same signature for both functions. In ogr2ogr we could then do something > like:
Ah, sorry. Evan suggested to introduce something like bExactMatch after I made the initial PR. So it was added in an incremental change here: https://github.com/jef-n/gdal/commit/a12311e56cf09d9deb15a18e93704377d1627c12#diff-156f2c76948ed9a6134f385f35e83165R499 Or the result of the merged changes: https://github.com/OSGeo/gdal/pull/23/files#diff-156f2c76948ed9a6134f385f35e83165R495 > int iDstField = bExactFieldNameMatch? > poDstLayer->GetFieldIndex(poSrcFieldDefn->GetNameRef()) : > poDstLayer->FindFieldIndex(poSrcFieldDefn->GetNameRef()); Do you prefer a second new OGRLayer method or did you mean: int iDstField = bExactFieldNameMatch? poDstFDefn->GetFieldIndex(poSrcFieldDefn->GetNameRef()) : poDstLayer->FindFieldIndex(poSrcFieldDefn->GetNameRef()); Jürgen -- Jürgen E. Fischer norBIT GmbH Tel. +49-4931-918175-31 Dipl.-Inf. (FH) Rheinstraße 13 Fax. +49-4931-918175-50 Software Engineer D-26506 Norden http://www.norbit.de -- norBIT Gesellschaft fuer Unternehmensberatung und Informationssysteme mbH Rheinstrasse 13, 26506 Norden GF: Jelto Buurman, HR: Amtsgericht Emden, HRB 5502 _______________________________________________ gdal-dev mailing list gdal-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/gdal-dev
