I didn't see any objections, so I'm going to go ahead and start removing the option and the #if cpp stuff.
On Thu, Mar 17, 2016 at 10:55 AM, Dmitry Baryshnikov <[email protected]> wrote: > Hi Kurt, > > I think, that it's time to do this. > > Best regards, > Dmitry > > 17.03.2016 19:19, Kurt Schwehr пишет: > > I propose that we remove --without-ogr and OGR_ENABLED. Happy to hear > arguments for the contrary. I commented here: > > https://trac.osgeo.org/gdal/ticket/6117 > > On Tue, Jun 23, 2015 at 9:14 AM, Even Rouault <[email protected]> > wrote: > >> Kor, >> >> I'm half surprised this ended up being broken. At the time of >> https://trac.osgeo.org/gdal/wiki/rfc46_gdal_ogr_unification, it still >> worked >> apparently but I might have accidentaly broken it later. >> >> Anyway I was wondering if it was worth fixing that? as it might be a >> continuing >> maintenance pain... This was something I actually considered during RFC >> 46 (I >> mean dropping support for --without-ogr). >> >> Even >> >> > Dear all, >> > >> > I may have found an issue in the build scripts of gdal 2.0.0. Building >> > gdal without ogr on Linux fails on my machine: >> > >> > ./configure --without-ogr >> > make -j8 >> > >> > I attached the output of configure and copied the snippets from the >> > build output detailing the errors below. >> > >> > When I change --without-ogr into --with-ogr, the build succeeds. >> > >> > Maybe something OGR-ish is building while it shouldn't(?). >> > >> > Best regards, >> > Kor de Jong >> > >> > >> > >> > >> > libtool: compile: /opt/gcc-4.9/bin/g++ -I/tmp/blah/gdal-2.0.0/port >> > -I/tmp/blah/gdal-2.0.0/gcore -I/tmp/blah/gdal-2.0.0/alg >> > -I/tmp/blah/gdal-2.0.0/ogr -I/tmp/blah/gdal-2.0.0/ogr/ogrsf_frmts -g -O2 >> > -Wall -I/tmp/blah/gdal-2.0.0/port -I/usr/include -DGDAL_COMPILATION -c >> > mffdataset.cpp -o ../o/mffdataset.o >/dev/null 2>&1 >> > ogrutils.cpp: In function ‘int OGRGeneralCmdLineProcessor(int, char***, >> > int)’: >> > ogrutils.cpp:526:60: error: ‘GDAL_OF_VECTOR’ was not declared in this >> scope >> > return GDALGeneralCmdLineProcessor( nArgc, ppapszArgv, >> > GDAL_OF_VECTOR ); >> > ^ >> > ogrutils.cpp:526:75: error: ‘GDALGeneralCmdLineProcessor’ was not >> > declared in this scope >> > return GDALGeneralCmdLineProcessor( nArgc, ppapszArgv, >> > GDAL_OF_VECTOR ); >> > >> > ^ >> > ogrutils.cpp:527:1: warning: control reaches end of non-void function >> > [-Wreturn-type] >> > } >> > ^ >> > make[1]: *** [ogrutils.lo] Error 1 >> > make[1]: *** Waiting for unfinished jobs.... >> > >> > >> > >> > >> > >> > pdfwritabledataset.cpp: In member function ‘virtual OGRErr >> > PDFWritableVectorDataset::SyncToDisk()’: >> > pdfwritabledataset.cpp:307:17: error: ‘class GDALPDFWriter’ has no >> > member named ‘WriteOGRLayer’ >> > oWriter.WriteOGRLayer((OGRDataSourceH)this, >> > ^ >> > make[2]: *** [../o/pdfwritabledataset.lo] Error 1 >> > make[2]: *** Waiting for unfinished jobs.... >> > >> > >> > >> > make[1]: *** [pdf-install-obj] Error 2 >> > make[1]: *** Waiting for unfinished jobs.... >> > make: *** [frmts-target] Error 2 >> >> -- >> Spatialys - Geospatial professional services >> http://www.spatialys.com >> _______________________________________________ >> gdal-dev mailing list >> [email protected] >> http://lists.osgeo.org/mailman/listinfo/gdal-dev > > > > > -- > -- > http://schwehr.org > > > _______________________________________________ > gdal-dev mailing > [email protected]http://lists.osgeo.org/mailman/listinfo/gdal-dev > > > > _______________________________________________ > gdal-dev mailing list > [email protected] > http://lists.osgeo.org/mailman/listinfo/gdal-dev > -- -- http://schwehr.org
_______________________________________________ gdal-dev mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/gdal-dev
