Lex Trotman schrieb:
Thomas,

Patch committed.
Thanks :)

2009/7/16 Thomas Martitz <thomas.mart...@student.htw-berlin.de <mailto:thomas.mart...@student.htw-berlin.de>>

    Thomas Martitz schrieb:

        I started working on the working dir. I have already
        implemeted the entry boxes, saving and loading it. I'm just
        mostly finished "%d".

        I'm thinking the basedir checkbox could be removed at the very
        end?

        Best regards.


    Alright, I've been coding the past few hours and this is what I
    got so far.

    It works pretty much as I expected. You fill out working dir, then
    it would 'cd' into that before executing the command. I'm not
    aware of big any issue, except that there are no default values
    yet (I'm not sure if they are needed if the default values would
    be just %d anyway).


Yeah, just leave them NULL.
One area that needs work is reading old config file [build-settings] to put %p/%d in the directory. Done & improved as well :-)

Alright, cool!



    %d and %p also work. I really think the basedir checkbox (and
    responsible code) could be removed.


Agreed, done

Couple of notes,

build_replace_placeholder requires that a document is open, but non-filetype commands don't require a document, obviously you can't substitute %d in that case & should give error like %p if no project, but you can still substitute %p.
Ahh yea, I forgot about the stupid user that try to compile or execute *no file* :D But yea, you're right it should be fixed.

Changed the dialog comment to just list the substitutes and refer to manual, it was too long & the dialog is now pretty big (IMHO the comment I had was always too long, its not just the latest additions)

Dialog fixed regular expression field span & use symbols for column counts.

Fixed stcmp to original code, the strlen is required because a NULL must compare equal to an empty string, that was really the point of stcmp. Otherwise extraneous entries are written to config files hiding things that should still be visible (took hours to find out why ;-).

Ah yes, did I change it? I didn't actually mean to (i.e. I had it changed locally but wanted to revert that part before putting a patch up), sorry for that.


Best regards.
_______________________________________________
Geany-devel mailing list
Geany-devel@uvena.de
http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel

Reply via email to