On Fri, 14 May 2010 20:07:54 +0200, Colomban wrote: > > > > Currently, the tab positioning (before/after all other tabs) is > > > > controlled by the boolean preference tab_order_ltr. Fine, but > > > > not to extend it. Then, I see two ways to go: > > > > 1. Change this to an integer (or something) that represent an > > > > enumeration: before all, before current, after all, after > > > > current. 2. Add a second preference to choose whether the tabs > > > > are added before/after the current or all tabs. > > > > > > > > I think that 1 is probably a little better from the user's > > > > point of view (not sure), but it would probably be a pain to > > > > implement, because it would need to change the type of a > > > > preference... the problem is to keep compatibility with > > > > previous configuration version. > > > > > > > > 2 is then probably the way to go; > > > > > > > > > Agreed > > > > +1. > > Both ways shouldn't change how the user would control the > > preference in the preferences dialog. > Yes, true. > > > But using a second pref in the code would make > > it easier to keep compatibility though it isn't as clean. I still > > would prefer way 2 too. > After actually hacking the code I'm not that sure that having two > preferences is necessarily worst since tab_order_ltr is used at place > where tab_order_beside wouldn't make sense (when opening a session for > example). > > > > > the pref UI could even hide the > > > > complexity. But then, some question comes to my mind: > > > > a. Which name give to this preference? > > > > > > > > > > tab_order_beside then tab_order_ltr says which side. > > > > Agreed. > Okay, there I go. > > > > > b. How to show it to the user? > > > > > > > > > > Placement of new tabs: X at end X beside current > > > X left X right > > > > > > But then not everyone likes my UI designs :-) > > > > Haha. > > I attached a little mockup (and code) how I would realise it though > > it's just my opinion. This doesn't mean it's better or worse than > > Lex' proposal. > I used your (Enrico's) design with minor tweaks 'cause I think it is > more clear and doesn't change the current UI that much. > > And then... there's the patch joined!
Thanks a lot, committed. Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc
signature.asc
Description: PGP signature
_______________________________________________ Geany-devel mailing list [email protected] http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
