On Thu, 5 Aug 2010 01:59:48 +0200 Jiří Techet <tec...@gmail.com> wrote:
> There was one more bug related to the tab switching. When we switch > so many times that we return back to the original document (so we > actually don't switch at all) then the following switch attempt > doesn't switch immediately to the next document. > > After spending two hours thinking what is wrong, I gave up and rewrote > the whole thing in a different way. The problem with the previous > implementation was that before you couldn't just look what's in the queue > "now" - you had to imagine what will be inserted there in the next step > because the switch_in_progress variable was set after the first switch > (this is also why I put the long comment why mru_pos = 2 - that is not > clear at all when you first look at it). Also there were some not very > nice "workarounds" like the idle function that was executed after the > switch and removed the double entry on top of the queue. > > So with the new implementation things are much simpler IMO. The queue > starts with the current document and the previously opened documments > follow. It's *always* like that, no exceptions. The idle function > is gone and cb_func_switch_tablastused() is simplified too. The rest of > the functionality should be clear from the code. Thanks, I'd like to commit this now. I realize it's been a while, but the patch doesn't apply cleanly and I can't see any commits since that would have caused conflicts. Any chance you could update and resubmit please? Regards, Nick _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel