On Wed, Sep 15, 2010 at 23:15, Colomban Wendling <lists....@herbesfolles.org> wrote: > Hi, > > Le 16/08/2010 02:51, Erik de Castro Lopo a écrit : >> Jiří Techet wrote: >> >>> >>> When reloading a file with ctrl+R don't display the warning dialog >>> that the unsaved changes might be lost when the file has not been >>> modified. >> >> I've been running with this patch for about a week. Looks good to me. > This one seems to have been applied as r5190, and I have a little > complain about it, so perhaps it would need a little more thought. > > The problem is that reloading a document not only looses unsaved > changes, but also undo/redo stack. This is particularly annoying if you > hit the shortcut by accident (which I unfortunately did :( ). > So I propose to two possible solutions: > 1) simply check whether there's possible undo/redo, and if yes, ask > before reloading (little patch joined); > 2) the solution 1 fixes my problem, but probably not (?) for somebody > that was annoyed by this dialog like Jiří was. So, perhaps a... setting > (!) would be useful?
(1) is OK with me. The moment when I found the previous behaviour annoying was when I created a new project, opened several files and then realized that the indent indent size in the project settings was different than the actual indents in the files. I modified the project settings but the open files had to be reloaded in order to get the new indent settings. The patch was meant to fix this little annoyance I had with confirming the dialog in a trivial way but if it's causing troubles in other situations, it's OK with me if the patch is reverted. The above situation is not something I run into every day. Jiri > > What do you think? > > Regards, > Colomban > > _______________________________________________ > Geany-devel mailing list > Geany-devel@uvena.de > http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel > > _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel