On 29 August 2012 04:02, Colomban Wendling <lists....@herbesfolles.org> wrote: > Hi guys, > > I took a look at #3041948 [1] and did a prototype patch (attached) to > fix it. Basically it's about the behavior of the Home and End keys > regarding wrapped lines. We have configurable keybindings already, but > they don't really make the editor display-line-friendly since they don't > change the behavior of <Shift>Home and <Shift>End, aka selection extension. > > Instead of repeating me, I'll quote the attached patch: > >> Add setting to make Home and End keys navigate in display coordinates >> >> This cannot really be mapped using the keybinding because holding >> Shift together with Home or End is expected to behave exactly the >> same as without it but extending the selection; which is tricky to >> get using configurable bindings. >> >> For this setting to behave correctly, the Home and End keys should >> obviously not be bound to any action, so the default bidings of Home >> and End should most probably be removed. Maybe the "Go to [display] >> line start/end" actions should be removed altogether now a global >> setting can be used to choose one behavior or the other; but they can >> also be kept but unmapped by default, which would allow a user to map >> another key to this action (like <Ctrl>A and <Ctrl>E to emulate a >> Bash/Emacs-like behavior). >> >> Closes #3041948. > > So, what do you think? Is this a correct way to fix this, or should we > rather either add (4) separate configurable bindings for extending the > selection to the start/end? Or should we add a trick to extend > selection when <Shift> is pressed together with one of the current > bindings (that's probably not a good idea in the (unlikely) case one > binds one of these actions to <Shift>Something)? > > Also, should we remove the bidings if we add that? Or should be just > not bind them by default? > > What about backward compatibility?
Hi Colomban, Backward compatibility is absolutely essential, Geany must ship working as it does now !!!!!!! I don't see the point of going to the end of the "visual" line since that is just some arbitrary point at which the line is wrapped, it is unlikely to be significant, except you might want to add a line break there. Going to the actual start and end of the line is much more common IMNSHO, so it should be the default (as it is now). If a user prefers to navigate by visual line, fine, they can change the bindings as you said. The best way of handling "extend selection to end of visible/real line" would be to also make those keybindings that the user can set, with defaults as now and <shift><alt>home/end for the extend visual. So again Geany works as now by default, the opposite behaviour is available, and users who prefer it can change the bindings to make it their default. Cheers Lex > > > Looking forward to read you :) > Regards, > Colomban > > > [1] > https://sourceforge.net/tracker/?func=detail&atid=787791&aid=3041948&group_id=153444 > > PS: This uses 2 new Scintilla (not yet released) commands to respect > "smart home key" feature when dealing with display lines, so you'll need > a patch for that too -- attached. > PPS: 3rd patch is to make "move to start of display line" command > respect the "smart home" feature, too. > > _______________________________________________ > Geany-devel mailing list > Geany-devel@uvena.de > https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel > _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
