Hello playmobil,
I'd like you to do a code review. Please execute
g4 diff -c 8115325
or point your web browser to
http://mondrian/8115325
to review the following code:
Change 8115325 by [EMAIL PROTECTED] on 2008/08/27 13:08:21 *pending*
Fix the compiler warnings in MacOSX for different visibility.
PRESUBMIT=passed
R=playmobil
[EMAIL PROTECTED]
DELTA=5 (3 added, 0 deleted, 2 changed)
OCL=8115325
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/config.mk#84 edit
5 delta lines: 3 added, 0 deleted, 2 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8115325 by [EMAIL PROTECTED] on 2008/08/27 13:08:21 *pending*
Fix the compiler warnings in MacOSX for different visibility.
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/config.mk#84 edit
==== //depot/googleclient/gears/opensource/gears/tools/config.mk#84 -
c:\src2/googleclient/gears/opensource/gears/tools/config.mk ====
# action=edit type=text
--- googleclient/gears/opensource/gears/tools/config.mk 2008-08-27
13:07:00.000000000 -0700
+++ googleclient/gears/opensource/gears/tools/config.mk 2008-08-27
12:23:42.000000000 -0700
@@ -439,6 +439,9 @@
# url_canon::Replacements::SetPort().
CXXFLAGS += -Wno-deprecated-declarations
+BREAKPAD_CPPFLAGS += -fvisibility=hidden
+BREAKPAD_CXXFLAGS += -fvisibility-inlines-hidden
+
THIRD_PARTY_CPPFLAGS += -fvisibility=hidden
THIRD_PARTY_CXXFLAGS += -fvisibility-inlines-hidden
@@ -600,8 +603,8 @@
SQLITE_CFLAGS += /wd4146
endif
-BREAKPAD_CPPFLAGS = /wd4018 /wd4003
-THIRD_PARTY_CPPFLAGS = /wd4018 /wd4003
+BREAKPAD_CPPFLAGS += /wd4018 /wd4003
+THIRD_PARTY_CPPFLAGS += /wd4018 /wd4003
# for PortAudio:
# warning C4133: 'type' : incompatible types - from 'type1' to 'type2'
# warning C4101: 'identifier' : unreferenced local variable
