Aaron, I think we should put this into the .dot release. On Tue, Sep 2, 2008 at 12:33 PM, Michael Nordman <[EMAIL PROTECTED]>wrote:
> Hello bpm, > > I'd like you to do a code review. Please execute > g4 diff -c 8143836 > > or point your web browser to > http://mondrian/8143836 > > to review the following code: > > Change 8143836 by [EMAIL PROTECTED] on 2008/08/29 18:05:49 > *pending* > > Fix for a crashing bug when Yahoo toolbar is installed. > > R=bpm > CC=aa,[email protected] > DELTA=29 (22 added, 1 deleted, 6 changed) > OCL=8143836 > > Affected files ... > > ... > //depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.cc#17 > edit > ... > //depot/googleclient/gears/opensource/gears/localserver/ie/http_request_ie.h#12 > edit > ... > //depot/googleclient/gears/opensource/gears/localserver/ie/progress_input_stream.cc#1 > edit > ... > //depot/googleclient/gears/opensource/gears/localserver/ie/progress_input_stream.h#1 > edit > > 29 delta lines: 22 added, 1 deleted, 6 changed > > Also consider running: > g4 lint -c 8143836 > > which verifies that the changelist doesn't introduce new style violations. > > If you can't do the review, please let me know as soon as possible. During > your review, please ensure that all new code has corresponding unit tests > and > that existing unit tests are updated appropriately. Visit > http://www/eng/code_review.html for more information. > > This is a semiautomated message from "g4 mail". Complaints or suggestions? > Mail [EMAIL PROTECTED] >
