Hello cprince,
I'd like you to do a code review. Please execute
g4 diff -c 8166551
or point your web browser to
http://mondrian/8166551
to review the following code:
Change 8166551 by [EMAIL PROTECTED] on 2008/09/03 10:24:11 *pending*
Remove the private_chrome makemore step from the pulse build.
R=cprince
[EMAIL PROTECTED]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=8166551
Affected files ...
...
//depot/googleclient/gears/opensource/gears/tools_internal/pulse_config_devbranch.txt#5
edit
1 delta lines: 0 added, 0 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8166551 by [EMAIL PROTECTED] on 2008/09/03 10:24:11 *pending*
Remove the private_chrome makemore step from the pulse build.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/tools_internal/pulse_config_devbranch.txt#5
edit
====
//depot/googleclient/gears/opensource/gears/tools_internal/pulse_config_devbranch.txt#5
-
C:\src\gears/googleclient/gears/opensource/gears/tools_internal/pulse_config_devbranch.txt
====
# action=edit type=text
---
googleclient/gears/opensource/gears/tools_internal/pulse_config_devbranch.txt
2008-09-03 10:27:26.000000000 -0700
+++
googleclient/gears/opensource/gears/tools_internal/pulse_config_devbranch.txt
2008-09-02 14:50:03.000000000 -0700
@@ -164,7 +164,7 @@
<macro name="define.tools.win32">
<property name="cmd.makemore" value="cmd.exe" />
- <property name="cmd.makemore.args" value="/c call
..\\..\\private_chrome\\gears\\make.bat" />
+ <property name="cmd.makemore.args" value="/c echo Nothing else required
for 'makemore' on Win32." />
</macro>
<macro name="define.tools.wince">
