Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 8202331
or point your web browser to
http://mondrian/8202331
to review the following code:
Change 8202331 by [EMAIL PROTECTED] on 2008/09/08 13:33:59 *pending*
Changes factory.getPermission and geolocation.getPermission methods so
that null values are accepted for the optional arguments.
This is a fix for bugs 693 and 694.
This CL follows on from CL 8202225.
R=andreip
[EMAIL PROTECTED]
DELTA=12 (0 added, 12 deleted, 0 changed)
OCL=8202331
Affected files ...
...
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.cc#7
edit
12 delta lines: 0 added, 12 deleted, 0 changed
Also consider running:
g4 lint -c 8202331
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8202331 by [EMAIL PROTECTED] on 2008/09/08 13:33:59 *pending*
Changes factory.getPermission and geolocation.getPermission methods so
that null values are accepted for the optional arguments.
This is a fix for bugs 693 and 694.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.cc#7
edit
====
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.cc#7 -
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/ui/common/permissions_dialog.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/ui/common/permissions_dialog.cc
2008-09-08 13:34:41.000000000 +0100
+++ googleclient/gears/opensource/gears/ui/common/permissions_dialog.cc
2008-09-08 13:25:15.000000000 +0100
@@ -153,18 +153,6 @@
if (context->is_exception_set())
return NULL;
- // If site_name was not provided, ignore value provided for image_url and
- // clear its value.
- if (!argv[0].was_specified) {
- image_url = STRING16(L"");
- }
-
- // If image_url or site_name was not provided, ignore value provided for
- // extra_message and clear its value.
- if (!argv[0].was_specified || !argv[1].was_specified) {
- extra_message = STRING16(L"");
- }
-
return new CustomContent(image_url.c_str(),
site_name.c_str(),
extra_message.c_str());
