======================================================================== http://mondrian.corp.google.com/file/8187986///depot/googleclient/gears/opensource/gears/base/common/js_runner_np.cc?a=1 File //depot/googleclient/gears/opensource/gears/base/common/js_runner_np.cc (snapshot 1) ------------------------------------ Line 187: bool InitializeModuleWrapper(ModuleImplBaseClass *module, On Mon Sep 8 11:43:01 2008 PDT, mpcomplete wrote: > Can you copy this to js_runner_cr.cc as well?
I think I already did, right? ======================================================================== http://mondrian.corp.google.com/file/8187986///depot/googleclient/gears/opensource/gears/base/npapi/module_wrapper.h?a=2 File //depot/googleclient/gears/opensource/gears/base/npapi/module_wrapper.h (snapshot 2) ------------------------------------ Line 107: impl->GetWrapper()->Unref(); On Mon Sep 8 11:48:20 2008 PDT, mpcomplete wrote: > Seems like we'll need to find a way to get rid of this when you move > CreateModule() to base/common. I'm assuming it'll have a common implementation > for all browsers then? You're right - we will need to find a way. I was planning to just have a "#if BROWSER_NPAPI" around this section. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/8187986
