Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 8229967
or point your web browser to
http://mondrian/8229967
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 8229967 by [EMAIL PROTECTED] on 2008/09/10 10:20:05 *pending*
Fix build bustage caused by 8221965 , the installer plugin was compiled
with $(DLLFLAGS)
which in the case of FF on OS X contains a list of symbols to export,
the installer plugin doesn't
contain these symbols so compilation fails.
The fix was to move these parameters into $(BROWSER)_DLLFLAGS.
PRESUBMIT=passed
R=andreip
[EMAIL PROTECTED]
DELTA=2 (0 added, 0 deleted, 2 changed)
OCL=8229967
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/config.mk#86 edit
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#90 edit
2 delta lines: 0 added, 0 deleted, 2 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8229967 by [EMAIL PROTECTED] on 2008/09/10 10:20:05 *pending*
Fix build bustage caused by 8221965 , the installer plugin was compiled
with $(DLLFLAGS)
which in the case of FF on OS X contains a list of symbols to export,
the installer plugin doesn't
contain these symbols so compilation fails.
The fix was to move these parameters into $(BROWSER)_DLLFLAGS.
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/config.mk#86 edit
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#90 edit
==== //depot/googleclient/gears/opensource/gears/tools/config.mk#86 -
/Users/playmobil/Documents/dev/gears/googleclient/gears/opensource/gears/tools/config.mk
====
# action=edit type=text
--- googleclient/gears/opensource/gears/tools/config.mk 2008-09-10
10:22:20.000000000 -0700
+++ googleclient/gears/opensource/gears/tools/config.mk 2008-09-10
09:48:36.000000000 -0700
@@ -478,7 +478,7 @@
DLLFLAGS += -mmacosx-version-min=10.4 -framework WebKit -lcurl
DLLFLAGS += -Ltools/osx -lleopard_support
else
-DLLFLAGS += -Wl,-exported_symbols_list -Wl,tools/xpcom-ld-script.darwin
+$(BROWSER)_DLLFLAGS += -Wl,-exported_symbols_list
-Wl,tools/xpcom-ld-script.darwin
endif
# for PortAudio: need CoreAudio, AudioToolbox, AudioUnit, Carbon frameworks
DLLFLAGS += -framework CoreAudio -framework AudioToolbox -framework AudioUnit
-framework Carbon
==== //depot/googleclient/gears/opensource/gears/tools/rules.mk#90 -
/Users/playmobil/Documents/dev/gears/googleclient/gears/opensource/gears/tools/rules.mk
====
# action=edit type=text
--- googleclient/gears/opensource/gears/tools/rules.mk 2008-09-10
10:22:20.000000000 -0700
+++ googleclient/gears/opensource/gears/tools/rules.mk 2008-09-10
09:51:34.000000000 -0700
@@ -976,7 +976,7 @@
$(STRIP_EXECUTABLE)
$(SF_INSTALLER_PLUGIN_EXE): $(SF_INSTALLER_PLUGIN_OBJS)
- $(MKDLL) $(DLLFLAGS) $($(BROWSER)_DLLFLAGS) $($(BROWSER)_LINK_EXTRAS)
-framework Cocoa -framework InstallerPlugins $(SF_INSTALLER_PLUGIN_OBJS)
+ $(MKDLL) $(DLLFLAGS) $($(BROWSER)_LINK_EXTRAS) -framework Cocoa
-framework InstallerPlugins $(SF_INSTALLER_PLUGIN_OBJS)
$(STRIP_EXECUTABLE)
$(SF_INPUTMANAGER_EXE): $(SF_INPUTMANAGER_OBJS)
