Hello jripley, nigeltao,
I'd like you to do a code review. Please execute
g4 diff -c 8241464
or point your web browser to
http://mondrian/8241464
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 8241464 by [EMAIL PROTECTED] on 2008/09/11 14:38:34 *pending*
Fixes Safari build bustage.
PRESUBMIT=passed
R=jripley,nigeltao
[EMAIL PROTECTED]
DELTA=3 (3 added, 0 deleted, 0 changed)
OCL=8241464
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#50 edit
3 delta lines: 3 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 8241464
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8241464 by [EMAIL PROTECTED] on 2008/09/11 14:38:34 *pending*
Fixes Safari build bustage.
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#50 edit
==== //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#50 -
/Users/steveblock/GearsOsx1/googleclient/gears/opensource/gears/desktop/desktop.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/desktop.cc 2008-09-11
14:38:47.000000000 +0100
+++ googleclient/gears/opensource/gears/desktop/desktop.cc 2008-09-11
14:29:54.000000000 +0100
@@ -38,6 +38,9 @@
#include "gears/base/common/security_model.h"
#include "gears/base/common/serialization.h"
#include "gears/base/common/url_utils.h"
+#ifdef BROWSER_SAFARI
+#include "gears/base/npapi/browser_utils.h"
+#endif
#ifdef BROWSER_WEBKIT
#include "gears/base/safari/curl_downloader.h"
#endif
