Hello aa,
I'd like you to do a code review. Please execute
g4 diff -c 8257380
or point your web browser to
http://mondrian/8257380
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 8257380 by [EMAIL PROTECTED] on 2008/09/12 10:57:37 *pending*
Specifically note that we only support G4, G5 and Intel CPUs.
PRESUBMIT=passed
R=aa
[EMAIL PROTECTED]
DELTA=2 (0 added, 0 deleted, 2 changed)
OCL=8257380
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/gears_faq.html#6 edit
2 delta lines: 0 added, 0 deleted, 2 changed
Also consider running:
g4 lint -c 8257380
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8257380 by [EMAIL PROTECTED] on 2008/09/12 10:57:37 *pending*
Specifically note that we only support G4, G5 and Intel CPUs.
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/gears_faq.html#6 edit
==== //depot/googleclient/gears/opensource/gears/sdk/gears_faq.html#6 -
/Users/playmobil/Documents/dev/gears/googleclient/gears/opensource/gears/sdk/gears_faq.html
====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/gears_faq.html 2008-09-12
10:57:43.000000000 -0700
+++ googleclient/gears/opensource/gears/sdk/gears_faq.html 2008-09-12
10:56:17.000000000 -0700
@@ -741,14 +741,14 @@
</p>
<ul>
<li>
- Apple Mac OS X (10.4 or higher)
+ Apple Mac OS X (10.4 or higher, G4, G5 or Intel Processor)
</li>
<ul>
<li>
Firefox 1.5 or higher
</li>
<li>
- Safari 3.1.1 or higher (requires OS X Tiger 10.4.11+ or Leopard
10.5.3+)
+ Safari 3.1.1 or higher (requires OS X Tiger 10.4.11+ or Leopard
10.5.3+, G4, G5 or Intel Processor)
</li>
</ul>
<li>