Hello andreip, jripley, aa, steveblock,
I'd like you to do a code review. Please execute
g4 diff -c 8271726
or point your web browser to
http://mondrian/8271726
to review the following code:
Change 8271726 by [EMAIL PROTECTED] on 2008/09/15 19:21:20 *pending*
Only displays the dialogs content when the texts strings are set.
PRESUBMIT=passed
R=andreip,jripley,aa,steveblock
[EMAIL PROTECTED]
DELTA=12 (12 added, 0 deleted, 0 changed)
OCL=8271726
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/parse_stab.py#7 edit
... //depot/googleclient/gears/opensource/gears/ui/common/html_dialog.css#5 edit
...
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4#3
edit
...
//depot/googleclient/gears/opensource/gears/ui/common/settings_dialog.html_m4#1
edit
...
//depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4#3
edit
12 delta lines: 12 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 8271726
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
