Hello mpcomplete,
I'd like you to do a code review. Please execute
g4 diff -c 8280550
or point your web browser to
http://mondrian/8280550
to review the following code:
Change 8280550 by [EMAIL PROTECTED] on 2008/09/16 17:09:29 *pending*
Remove unused EnvPageJsContext and EnvPageIUnknownSite
methods.
PRESUBMIT=passed
R=mpcomplete
[EMAIL PROTECTED]
DELTA=18 (0 added, 18 deleted, 0 changed)
OCL=8280550
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/base_class.cc#19
edit
... //depot/googleclient/gears/opensource/gears/base/common/base_class.h#22 edit
18 delta lines: 0 added, 18 deleted, 0 changed
Also consider running:
g4 lint -c 8280550
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8280550 by [EMAIL PROTECTED] on 2008/09/16 17:09:29 *pending*
Remove unused EnvPageJsContext and EnvPageIUnknownSite
methods.
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/base_class.cc#19
edit
... //depot/googleclient/gears/opensource/gears/base/common/base_class.h#22 edit
==== //depot/googleclient/gears/opensource/gears/base/common/base_class.cc#19 -
/home/nigeltao/srcgears4/googleclient/gears/opensource/gears/base/common/base_class.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/common/base_class.cc
2008-09-16 17:14:27.000000000 +1000
+++ googleclient/gears/opensource/gears/base/common/base_class.cc
2008-09-16 17:09:36.000000000 +1000
@@ -154,18 +154,6 @@
return module_environment_->security_origin_.full_url();
}
-#if BROWSER_FF || BROWSER_NPAPI
-JsContextPtr ModuleImplBaseClass::EnvPageJsContext() const {
- assert(module_environment_.get());
- return module_environment_->js_context_;
-}
-#elif BROWSER_IE
-IUnknown* ModuleImplBaseClass::EnvPageIUnknownSite() const {
- assert(module_environment_.get());
- return module_environment_->iunknown_site_;
-}
-#endif
-
const SecurityOrigin& ModuleImplBaseClass::EnvPageSecurityOrigin() const {
assert(module_environment_.get());
return module_environment_->security_origin_;
==== //depot/googleclient/gears/opensource/gears/base/common/base_class.h#22 -
/home/nigeltao/srcgears4/googleclient/gears/opensource/gears/base/common/base_class.h
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/common/base_class.h
2008-09-16 17:14:28.000000000 +1000
+++ googleclient/gears/opensource/gears/base/common/base_class.h
2008-09-16 17:10:03.000000000 +1000
@@ -138,13 +138,7 @@
void GetModuleEnvironment(scoped_refptr<ModuleEnvironment> *out) const;
bool EnvIsWorker() const;
const std::string16& EnvPageLocationUrl() const;
-#if BROWSER_FF || BROWSER_NPAPI
- JsContextPtr EnvPageJsContext() const;
-#elif BROWSER_IE
- IUnknown* EnvPageIUnknownSite() const;
-#endif
const SecurityOrigin& EnvPageSecurityOrigin() const;
-
BrowsingContext *EnvPageBrowsingContext() const;
JsRunnerInterface *GetJsRunner() const;
