Anyone w/JS can feel free to approve! http://mondrian.corp.google.com/8287985
On Tue, Sep 16, 2008 at 2:32 PM, Scott Hess <[EMAIL PROTECTED]> wrote: > I had an elaborate argument why the || version was lazier WRT backing > things out, but then realized that not changing the assert is even > lazier if you ignore whitespace! > > Michael, I need an approval on this. Sorry to not have looped you in earlier. > > -scott > > > On Tue, Sep 16, 2008 at 2:21 PM, Jeremy Moskovich <[EMAIL PROTECTED]> wrote: >> LGTM >> >> ======================================================================== >> http://mondrian.corp.google.com/file/8287985///depot/googleclient/gears/opensource/gears/test/testcases/database_fts_tests.js?a=1 >> File >> //depot/googleclient/gears/opensource/gears/test/testcases/database_fts_tests.js >> (snapshot 1) >> ------------------------------------ >> Line 281: assert(expected.exec(error.message) || isSafariWorker, >> maybe a little clearer: >> if(!isSafariWorker) { >> assert(); >> } >> ======================================================================== >> >> -- >> To respond, reply to this email or visit >> http://mondrian.corp.google.com/8287985 >> >
