Hello mpcomplete,
I'd like you to do a code review. Please execute
g4 diff -c 8295426
or point your web browser to
http://mondrian/8295426
to review the following code:
Change 8295426 by [EMAIL PROTECTED] on 2008/09/17 20:44:41 *pending*
Safari / Spidermonkey clean-up fix for the JsTokenEqualTo object
introduced by 8267527 "Push JsToken-manipulating functions ...
[into] JsRunnerInterface".
PRESUBMIT=passed
R=mpcomplete
[EMAIL PROTECTED]
DELTA=2 (2 added, 0 deleted, 0 changed)
OCL=8295426
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/js_runner_np.cc#27
edit
2 delta lines: 2 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 8295426
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8295426 by [EMAIL PROTECTED] on 2008/09/17 20:44:41 *pending*
Safari / Spidermonkey clean-up fix for the JsTokenEqualTo object
introduced by 8267527 "Push JsToken-manipulating functions ...
[into] JsRunnerInterface".
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/js_runner_np.cc#27
edit
==== //depot/googleclient/gears/opensource/gears/base/common/js_runner_np.cc#27
-
/Users/nigeltao/devel/srcmacgears1/googleclient/gears/opensource/gears/base/common/js_runner_np.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/common/js_runner_np.cc
2008-09-17 18:50:42.000000000 +1000
+++ googleclient/gears/opensource/gears/base/common/js_runner_np.cc
2008-09-17 19:08:56.000000000 +1000
@@ -93,6 +93,7 @@
virtual ~JsRunnerBase() {
// Should have called Cleanup() to kill this before getting here();
+ assert(np_variant_comparator_.get() == NULL);
assert(evaluator_.get() == NULL);
for (int i = 0; i < MAX_JSEVENTS; i++) {
assert(0 == event_handlers_[i].size());
@@ -106,6 +107,7 @@
// to be succesfully destructed.
void Cleanup() {
evaluator_.reset(NULL);
+ np_variant_comparator_.reset(NULL);
}
bool AddGlobal(const std::string16 &name, ModuleImplBaseClass *object) {
