Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 8305288
or point your web browser to
http://mondrian/8305288
to review the following code:
Change 8305288 by [EMAIL PROTECTED] on 2008/09/18 01:16:05 *pending*
Fixes unit test bustage due to merge problem in CL 8303317.
R=andreip
[EMAIL PROTECTED]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=8305288
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc#25
edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 8305288
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8305288 by [EMAIL PROTECTED] on 2008/09/18 01:16:05 *pending*
Fixes unit test bustage due to merge problem in CL 8303317.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc#25
edit
====
//depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc#25
-
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/geolocation/network_location_request.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/network_location_request.cc
2008-09-18 14:36:07.000000000 +0100
+++ googleclient/gears/opensource/gears/geolocation/network_location_request.cc
2008-09-18 01:15:27.000000000 +0100
@@ -32,7 +32,7 @@
#include "third_party/jsoncpp/value.h"
#include "third_party/jsoncpp/writer.h"
-static const char *kGearsNetworkLocationProtocolVersion = "1.0";
+static const char *kGearsNetworkLocationProtocolVersion = "1.0.1";
static const char *kLatitudeString = "latitude";
static const char *kLongitudeString = "longitude";
