Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 8310426
or point your web browser to
http://mondrian/8310426
to review the following code:
Change 8310426 by [EMAIL PROTECTED] on 2008/09/18 16:10:13 *pending*
Updates documentation to reflect JSON protocol version 1.0.1.
This follows on from CLs 8171244 and 8177278.
R=andreip
[EMAIL PROTECTED]
DELTA=8 (0 added, 0 deleted, 8 changed)
OCL=8310426
Affected files ...
...
//depot/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html#1
edit
8 delta lines: 0 added, 0 deleted, 8 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8310426 by [EMAIL PROTECTED] on 2008/09/18 16:10:13 *pending*
Updates documentation to reflect JSON protocol version 1.0.1.
This follows on from CLs 8171244 and 8177278.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html#1
edit
====
//depot/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html#1
-
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html
====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html
2008-09-18 16:15:25.000000000 +0100
+++ googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html
2008-09-18 16:12:53.000000000 +0100
@@ -86,7 +86,7 @@
<pre><code>
{
- "version": "1.0",
+ "version": "1.0.1",
"host": "maps.google.com",
"home_mobile_country_code": 310,
"home_mobile_network_code": 410,
@@ -140,9 +140,9 @@
"location": {
"latitude": 51.0,
"longitude": -0.1,
- "altitude": 30,
- "horizontal_accuracy": 1200,
- "vertical_accuracy": 10,
+ "altitude": 30.1,
+ "horizontal_accuracy": 1200.4,
+ "vertical_accuracy": 10.6,
"address": {
"street_number": "100",
"street": "Amphibian Walkway",
@@ -170,7 +170,7 @@
</tr>
<tr>
<td class="nameColumn">version</td>
- <td class="descriptionColumn">The protocol version, currently, "1.0".</td>
+ <td class="descriptionColumn">The protocol version, currently,
"1.0.1".</td>
<td class="requiredColumn">Yes</td>
<td class="typeColumn">string</td>
</tr>
@@ -393,19 +393,19 @@
<td class="nameColumn">altitude</td>
<td class="descriptionColumn">Altitude of the fix, in meters (WGS84
datum).</td>
<td class="requiredColumn">No</td>
- <td class="typeColumn">int</td>
+ <td class="typeColumn">double</td>
</tr>
<tr>
<td class="nameColumn">horizontal_accuracy</td>
<td class="descriptionColumn">The horizontal accuracy of the fix, in
meters at a 95% confidence level.</td>
<td class="requiredColumn">No</td>
- <td class="typeColumn">int</td>
+ <td class="typeColumn">double</td>
</tr>
<tr>
<td class="nameColumn">vertical_accuracy</td>
<td class="descriptionColumn">The vertical accuracy of the fix, in
meters.</td>
<td class="requiredColumn">No</td>
- <td class="typeColumn">int</td>
+ <td class="typeColumn">double</td>
</tr>
<tr>
<td class="nameColumn">address</td>
