> ======================================================================== > http://mondrian.corp.google.com/file/8176910///depot/googleclient/gears/opensource/gears/geolocation/geolocation_db.cc?a=1 > File > //depot/googleclient/gears/opensource/gears/geolocation/geolocation_db.cc > (snapshot 1) > ------------------------------------ > Line 98: !position_table_.Create() || > To be consistent with the rest of Gears, should this not be > "position_table_.CreateTableLatestVersion()" ? I was taking the name from NameValueTable::MaybeCreateTable. I dropped the 'Maybe' because this method should not be called if the table exists (see Scott's comment in shortcut_table.cc). However, you're right that the other tables use 'MaybeCreateTableLatestVersion'. I've updated the code to use CreateTableLatestVersion'.
> ======================================================================== > http://mondrian.corp.google.com/file/8176910///depot/googleclient/gears/opensource/gears/geolocation/network_location_provider.cc?a=1 > File > //depot/googleclient/gears/opensource/gears/geolocation/network_location_provider.cc > (snapshot 1) > ------------------------------------ > Line 105: RefCount listener_count_; > listener_count_? Isn't user_count_ closer to what we mean here? Sure, changed. > ======================================================================== > http://mondrian.corp.google.com/file/8176910///depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc?a=2 > File > //depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc > (snapshot 2) > ------------------------------------ > Line 41: static const char *kAccuracyString = "accuracy"; > Remember to update the docs! Done. New snapshot uploaded. Steve
