Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 8337915
or point your web browser to
http://mondrian/8337915
to review the following code:
Change 8337915 by [EMAIL PROTECTED] on 2008/09/22 12:30:11 *pending*
Disables testAsyncTaskPostCookies for Chrome pending bug fix.
R=andreip
[EMAIL PROTECTED]
DELTA=2 (1 added, 0 deleted, 1 changed)
OCL=8337915
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/internal_tests.js#36
edit
2 delta lines: 1 added, 0 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8337915 by [EMAIL PROTECTED] on 2008/09/22 12:30:11 *pending*
Disables testAsyncTaskPostCookies for Chrome pending bug fix.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/internal_tests.js#36
edit
====
//depot/googleclient/gears/opensource/gears/test/testcases/internal_tests.js#36
-
c:\MyDocs\Gears4/googleclient/gears/opensource/gears/test/testcases/internal_tests.js
====
# action=edit type=text
--- googleclient/gears/opensource/gears/test/testcases/internal_tests.js
2008-09-22 12:40:09.000000000 +0100
+++ googleclient/gears/opensource/gears/test/testcases/internal_tests.js
2008-09-22 12:28:58.000000000 +0100
@@ -663,7 +663,8 @@
}
function testAsyncTaskPostCookies() {
- if (isUsingCCTests) {
+ // TODO(steveblock): Enable this test for Chrome when bug 1301226 is fixed.
+ if (isUsingCCTests && !(isWin32 && isNPAPI)) {
var setCookieUrl = "/testcases/set_cookie.txt";
var serveIfCookiesPresentUrl = "/testcases/serve_if_cookies_present.txt";
var serveIfCookiesAbsentUrl = "/testcases/serve_if_cookies_absent.txt";
