LGTM just looked at the python code, a few comments below:
======================================================================== http://mondrian.corp.google.com/file/8228410///depot/googleclient/gears/opensource/gears/test/runner/testwebserver.py?a=1 File //depot/googleclient/gears/opensource/gears/test/runner/testwebserver.py (snapshot 1) ------------------------------------ Line 136: # The AyncTask unit tests rely on conditionally serving files based on the replace # with """ (similar to def isCgiCall(self) ------------------------------------ Line 149: can_serve = True couldn't find any use for this local "can_server" ------------------------------------ Line 150: if self.can_serve() == False: perhaps if not self.can_serve(): ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/8228410
