======================================================================== http://mondrian.corp.google.com/file/8203035///depot/googleclient/gears/opensource/gears/test/testcases/config.js?a=1 File //depot/googleclient/gears/opensource/gears/test/testcases/config.js (snapshot 1) ------------------------------------ Line 136: internalTestSuite.addFile('../testcases/internal_geolocation_tests.js', some whitespace suddenly appeared at the end of the line ======================================================================== http://mondrian.corp.google.com/file/8203035///depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js?a=2 File //depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js (snapshot 2) ------------------------------------ Line 138: // Tests extracting a position object from the JSON reposnse from a network from the JSON what? :) ------------------------------------ Line 254: // Test good response with malformed body. Please add a test that exposes the behavior that sumitg has found (i.e. jsoncpp reporting parsing success and returning a string instead of an object). Also add the corresponding bug number to this CL since this will help prove we fixed the bug and also catch future regressions. ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/8203035
