Hi All, I am new to this group. I am ineterested to contribute. As a first step towards this goal, I want to participate in code review. Where to start, can some one give some pointers about this?
Thx, Pujari. On Fri, Sep 26, 2008 at 11:43 AM, Steve Block <[EMAIL PROTECTED]> wrote: > ************************* G4 reminder ************************* > These new files: > > > > c:\MyDocs\Gears3\googleclient\gears\opensource\gears\geolocation\reverse_geocoder.cc > > are missing unit tests. > *************************************************************** > > Hello andreip, > > I'd like you to do a code review. Please execute > g4 diff -c 8305270 > > or point your web browser to > http://mondrian/8305270 > > to review the following code: > > Change 8305270 by [EMAIL PROTECTED] on 2008/09/18 01:15:07 > *pending* > > Adds reverse-geocoding for GPS location providers. > > There are a couple of TODOs here, relating to the access token and > exponential backoff. > These will be fixed in a separate CL, as this CL is already becoming > large. > > Also, this CL will require changes to the GPS location provider for > Android. > > R=andreip > [EMAIL PROTECTED] > DELTA=588 (416 added, 85 deleted, 87 changed) > OCL=8305270 > > Affected files ... > > ... //depot/googleclient/gears/opensource/gears/Makefile#185 edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/geolocation.cc#52 > edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/geolocation.h#22 > edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/geolocation_test.cc#25 > edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/gps_location_provider_wince.cc#10 > edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/gps_location_provider_wince.h#4 > edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/location_provider.cc#15 > edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/location_provider.h#12 > edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/location_provider_pool.cc#11 > edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/location_provider_pool.h#8 > edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc#28 > edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/network_location_request.h#7 > edit > ... > //depot/googleclient/gears/opensource/gears/geolocation/reverse_geocoder.cc#1 > add > ... > //depot/googleclient/gears/opensource/gears/geolocation/reverse_geocoder.h#1 > add > > 588 delta lines: 416 added, 85 deleted, 87 changed > > Also consider running: > g4 lint -c 8305270 > > which verifies that the changelist doesn't introduce new style violations. > > If you can't do the review, please let me know as soon as possible. During > your review, please ensure that all new code has corresponding unit tests > and > that existing unit tests are updated appropriately. Visit > http://www/eng/code_review.html for more information. > > This is a semiautomated message from "g4 mail". Complaints or suggestions? > Mail [EMAIL PROTECTED] >
