Hi All, How can I participate in actual code review?
Thx. On Mon, Sep 29, 2008 at 11:56 AM, Zach Kuznia <[EMAIL PROTECTED]> wrote: > Hello mpcomplete, > > I'd like you to do a code review. Please execute > g4 diff -c 8421912 > > or point your web browser to > http://mondrian/8421912 > > to review the following code: > > Change 8421912 by [EMAIL PROTECTED] on 2008/09/29 11:53:53 *pending* > > Remove browser utils from chrome directory and integrate the > difference into the npapi version. > > R=mpcomplete > [EMAIL PROTECTED] > DELTA=148 (10 added, 137 deleted, 1 changed) > OCL=8421912 > > Affected files ... > > ... > //depot/googleclient/gears/opensource/gears/base/chrome/browser_utils.cc#1 > delete > ... > //depot/googleclient/gears/opensource/gears/base/npapi/browser_utils.cc#5 > edit > > 148 delta lines: 10 added, 137 deleted, 1 changed > > Also consider running: > g4 lint -c 8421912 > > which verifies that the changelist doesn't introduce new style violations. > > If you can't do the review, please let me know as soon as possible. During > your review, please ensure that all new code has corresponding unit tests > and > that existing unit tests are updated appropriately. Visit > http://www/eng/code_review.html for more information. > > This is a semiautomated message from "g4 mail". Complaints or suggestions? > Mail [EMAIL PROTECTED] >
