Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 8526400
or point your web browser to
http://mondrian/8526400
to review the following code:
Change 8526400 by [EMAIL PROTECTED] on 2008/10/08 11:46:13 *pending*
Fixes unit test bustage due to addition of reverse geocoding for GPS
location providers.
R=andreip
[EMAIL PROTECTED]
DELTA=7 (0 added, 4 deleted, 3 changed)
OCL=8526400
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/geolocation_test.cc#26
edit
...
//depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js#2
edit
7 delta lines: 0 added, 4 deleted, 3 changed
Also consider running:
g4 lint -c 8526400
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8526400 by [EMAIL PROTECTED] on 2008/10/08 11:46:13 *pending*
Fixes unit test bustage due to addition of reverse geocoding for GPS
location providers.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/geolocation_test.cc#26
edit
...
//depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js#2
edit
====
//depot/googleclient/gears/opensource/gears/geolocation/geolocation_test.cc#26
-
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/geolocation/geolocation_test.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/geolocation_test.cc
2008-10-08 12:17:38.000000000 +0100
+++ googleclient/gears/opensource/gears/geolocation/geolocation_test.cc
2008-10-08 11:57:04.000000000 +0100
@@ -304,9 +304,9 @@
wifi_data,
true,
STRING16(L"en-GB"),
- 53.1,
- -0.1,
- false, // is_reverse_geocode_
+ 0.0, // Unused
+ 0.0, // Unused
+ false, // is_reverse_geocode
&blob)) {
context->SetException(STRING16(L"Failed to form request body."));
return;
====
//depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js#2
-
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js
====
# action=edit type=text
---
googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js
2008-10-08 12:17:38.000000000 +0100
+++
googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js
2008-10-08 11:57:23.000000000 +0100
@@ -123,10 +123,6 @@
'"signal_strength" : -65 ' +
'} ], ' +
'"host" : "www.google.com", ' +
- '"location" : { ' +
- '"latitude" : 53.1, ' +
- '"longitude" : -0.1 ' +
- '}, ' +
'"radio_type" : "gsm", ' +
'"request_address" : true, ' +
'"version" : "1.1.0", ' +
