Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 8529449
or point your web browser to
http://mondrian/8529449
to review the following code:
Change 8529449 by [EMAIL PROTECTED] on 2008/10/08 18:22:58 *pending*
Updates Geolocation JSON protocol to use integer type for cell ID, as
is currently in use.
R=andreip
[EMAIL PROTECTED]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=8529449
Affected files ...
...
//depot/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html#4
edit
1 delta lines: 0 added, 0 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8529449 by [EMAIL PROTECTED] on 2008/10/08 18:22:58 *pending*
Updates Geolocation JSON protocol to use integer type for cell ID, as
is currently in use.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html#4
edit
====
//depot/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html#4
-
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html
====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html
2008-10-09 10:20:50.000000000 +0100
+++ googleclient/gears/opensource/gears/sdk/geolocation_network_protocol.html
2008-10-09 10:16:38.000000000 +0100
@@ -280,7 +280,7 @@
<td class="nameColumn">cell_id</td>
<td class="descriptionColumn">Unique identifier of the cell. (CID for GSM,
BID for CDMA)</td>
<td class="requiredColumn">No</td>
- <td class="typeColumn">string</td>
+ <td class="typeColumn">int</td>
</tr>
<tr>
<td class="nameColumn">location_area_code</td>
