Hello steveblock,
*** I'm actually not sure why it doesn't build for me, since it works on
pulse.
I'd like you to do a code review. Please execute
g4 diff -c 8550841
or point your web browser to
http://mondrian/8550841
to review the following code:
Change 8550841 by [EMAIL PROTECTED] on 2008/10/09 16:40:14 *pending*
Fix Linux Firefox build.
R=steveblock
[EMAIL PROTECTED]
DELTA=1 (1 added, 0 deleted, 0 changed)
OCL=8550841
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/backoff_manager.cc#1
edit
1 delta lines: 1 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 8550841
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8550841 by [EMAIL PROTECTED] on 2008/10/09 16:40:14 *pending*
Fix Linux Firefox build.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/backoff_manager.cc#1
edit
====
//depot/googleclient/gears/opensource/gears/geolocation/backoff_manager.cc#1 -
C:\src\chrome\src\gears/googleclient/gears/opensource/gears/geolocation/backoff_manager.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/backoff_manager.cc
2008-10-09 16:40:23.000000000 -0700
+++ googleclient/gears/opensource/gears/geolocation/backoff_manager.cc
2008-10-09 16:39:03.000000000 -0700
@@ -23,6 +23,7 @@
// OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
// ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#include <assert.h>
#include "gears/geolocation/backoff_manager.h"
// The baseline minimum period between network requests.
