Hello andreip, zork,
I'd like you to do a code review. Please execute
g4 diff -c 8598136
or point your web browser to
http://mondrian/8598136
to review the following code:
Change 8598136 by [EMAIL PROTECTED] on 2008/10/15 00:08:15 *pending*
Removes help section from permissions dialog, which has been unused
since CL 7342044.
Should I remove the translated strings too, or will this be taken care
of throught the translation console?
R=andreip,zork
[EMAIL PROTECTED]
DELTA=72 (0 added, 72 deleted, 0 changed)
OCL=8598136
Affected files ...
...
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4#3
edit
...
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.js.stab#4
edit
72 delta lines: 0 added, 72 deleted, 0 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8598136 by [EMAIL PROTECTED] on 2008/10/15 00:08:15 *pending*
Removes help section from permissions dialog, which has been unused
since CL 7342044.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4#3
edit
...
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.js.stab#4
edit
====
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4#3
-
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4
====
# action=edit type=text
--- googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4
2008-09-17 13:14:21.000000000 +0100
+++ googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4
2008-10-15 00:10:35.000000000 +0100
@@ -136,11 +136,6 @@
padding:0 1em;
~)
}
-
- #permissions-help {
- margin:4px;
- display:none;
- }
</style>
</head>
<body>
@@ -153,29 +148,6 @@
<div id="string-trust-site-accesskey"></div>
</div>
- <!--
- PIE only works with one window, and we are in a modal dialog.
- Using window.open(this.href) replaces the content of the current dialog,
- which is annoying when no back button is displayed...
- The workaround is to embed directly a short explanation text, and
- hide/show the div container for the help and the settings dialog.
- -->
-
- <div id="permissions-help">
- <h2>Information</h2>
- <p>
- <span id="string-description"></span>
- </p>
- <ul>
- <li><span id="string-localserver-desc"></span></li>
- <li><span id="string-database-desc"></span></li>
- <li><span id="string-workerpool-desc"></span></li>
- </ul>
- <a href="#" onclick="showHelp(false); return false;">Go back</a>
- </div>
-
-m4_ifelse(PRODUCT_OS,~wince~,m4_dnl
-~ <div id="permissions-settings">~)
<div id="head">
<table width="100%" cellpadding="0" cellspacing="0" border="0">
<tr>
@@ -322,8 +294,6 @@
</div>
</div>
m4_ifelse(PRODUCT_OS,~wince~,m4_dnl
-~ </div>~)
-m4_ifelse(PRODUCT_OS,~wince~,m4_dnl
~<object style="display:none;"
classid="clsid:134AB400-1A81-4fc8-85DD-29CD51E9D6DE" id="pie_dialog">
</object>~)
</body>
@@ -384,26 +354,6 @@
}
}
- function showHelp(show) {
- if (browser.ie_mobile) {
- var elemSettings = dom.getElementById("permissions-settings");
- var elemHelp = dom.getElementById("permissions-help");
- if (show) {
- elemSettings.style.display = 'none';
- elemHelp.style.display = 'block';
- window.pie_dialog.SetButton("Back", "showHelp(false);");
- window.pie_dialog.SetButtonEnabled(true);
- } else {
- elemSettings.style.display = 'block';
- elemHelp.style.display = 'none';
- window.pie_dialog.SetButton("Allow", "allowAccessPermanently();");
- }
- window.pie_dialog.ResizeDialog();
- } else {
- window.open('http://gears.google.com/?action=help');
- }
- }
-
function initWarning() {
var args;
if (debug) {
====
//depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.js.stab#4
-
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/ui/common/permissions_dialog.js.stab
====
# action=edit type=text
--- googleclient/gears/opensource/gears/ui/common/permissions_dialog.js.stab
2008-10-15 10:49:24.000000000 +0100
+++ googleclient/gears/opensource/gears/ui/common/permissions_dialog.js.stab
2008-10-15 00:08:54.000000000 +0100
@@ -6,28 +6,6 @@
<string id="string-cancel"><TRANS_BLOCK desc="Button user can press to cancel
the dialog.">Cancel</TRANS_BLOCK></string>
<string id="string-never-allow-link"><TRANS_BLOCK desc="Link that disallows
Gears on this site.">Never allow this site</TRANS_BLOCK></string>
<string id="string-never-allow-link-wince"><TRANS_BLOCK desc="Link that
disallows Gears on this site for WinCE.">Never allow it</TRANS_BLOCK></string>
-<string id="string-description">
- <TRANS_BLOCK desc="Header for basic help section.">
- Gears is an open source browser extension that enables
- web applications to provide offline functionality using the following
- JavaScript APIs:
- </TRANS_BLOCK>
-</string>
-<string id="string-localserver-desc">
- <TRANS_BLOCK desc="Short explanation of localserver">
- Store and serve application resources locally
- </TRANS_BLOCK>
-</string>
-<string id="string-database-desc">
- <TRANS_BLOCK desc="Short explanation of database">
- Store data locally in a fully-searchable relational database
- </TRANS_BLOCK>
-</string>
-<string id="string-workerpool-desc">
- <TRANS_BLOCK desc="Short explanation of workerpool">
- Run asynchronous JavaScript to improve application responsiveness
- </TRANS_BLOCK>
-</string>
<string id="string-query-data">
<TRANS_BLOCK desc="Asks the user if they want to let the site use Gears to
store data locally on her device / computer.">
The website below wants to store information on your computer
