========================================================================
http://mondrian.corp.google.com/file/8588861///depot/googleclient/gears/opensource/gears/localserver/firefox/http_request_ff.cc?a=1
File
//depot/googleclient/gears/opensource/gears/localserver/firefox/http_request_ff.cc
(snapshot 1)
------------------------------------
Line 106: nsCOMPtr<nsIHttpChannel> http_channel(do_QueryInterface(channel_));
On Tue Oct 14 11:36:18 2008 PDT, michaeln wrote:
> I think this will return NULL for file:// urls. We have some degree of support
> for file urls in the HttpRequest class (despite its name). Maybe instead of
> assert(http_channel) return NS_OK in that case?
That (assertion failure on file:: URLs) is a separate bug from this one (we're
leaking a nsIHttpChannel) reference, right? I'd make it a separate CL, then, so
I've added a TODO.
------------------------------------
Line 164: do_GetService(kObserverServiceContractId));
On Tue Oct 14 11:38:52 2008 PDT, michaeln wrote:
> Maybe reorder the logic to defer the call to do_GetService? The usual case is
> observer_ == NULL.
>
> if (observer_) {
> do_GetService(...);
> blah
> }
Done.
========================================================================
--
To respond, reply to this email or visit http://mondrian.corp.google.com/8588861
