Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 8634724
or point your web browser to
http://mondrian/8634724
to review the following code:
Change 8634724 by [EMAIL PROTECTED] on 2008/10/17 14:15:11 *pending*
Fixes LocalServer tests to skip unimplemented API calls on WinCE.
R=andreip
[EMAIL PROTECTED]
DELTA=27 (15 added, 0 deleted, 12 changed)
OCL=8634724
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/localserver_capturefile_tests.js#1
edit
...
//depot/googleclient/gears/opensource/gears/test/testcases/localserver_tests.js#6
edit
27 delta lines: 15 added, 0 deleted, 12 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8634724 by [EMAIL PROTECTED] on 2008/10/17 14:15:11 *pending*
Fixes LocalServer tests to skip unimplemented API calls on WinCE.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/localserver_capturefile_tests.js#1
edit
...
//depot/googleclient/gears/opensource/gears/test/testcases/localserver_tests.js#6
edit
====
//depot/googleclient/gears/opensource/gears/test/testcases/localserver_capturefile_tests.js#1
-
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/test/testcases/localserver_capturefile_tests.js
====
# action=edit type=text
---
googleclient/gears/opensource/gears/test/testcases/localserver_capturefile_tests.js
2008-10-17 14:57:36.000000000 +0100
+++
googleclient/gears/opensource/gears/test/testcases/localserver_capturefile_tests.js
2008-10-17 15:08:39.000000000 +0100
@@ -2,6 +2,13 @@
var resourceStore = localServer.createStore('noworker_tests');
function testCreateFileSubmitter() {
+ if (isWince) {
+ assertError(
+ function() {resourceStore.createFileSubmitter()},
+ 'createFileSubmitter is not implemented',
+ 'createFileSubmitter is not yet implemented on WinCE');
+ return;
+ }
assertNotNull(resourceStore.createFileSubmitter(),
'Could not create FileSubmitter');
}
====
//depot/googleclient/gears/opensource/gears/test/testcases/localserver_tests.js#6
-
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/test/testcases/localserver_tests.js
====
# action=edit type=text
--- googleclient/gears/opensource/gears/test/testcases/localserver_tests.js
2008-10-14 14:18:11.000000000 +0100
+++ googleclient/gears/opensource/gears/test/testcases/localserver_tests.js
2008-10-17 14:53:45.000000000 +0100
@@ -322,18 +322,26 @@
}
function testCaptureBlob() {
- startAsync();
- var url = '/testcases/test_file_1024.txt';
- httpGetAsRequest(url, function(request) {
- var store = getFreshStore();
- var captureUrl = '/captured.txt';
- var responseBlob = request.responseBlob;
- store.captureBlob(responseBlob, captureUrl);
- httpGetAsRequest(captureUrl, function(request2) {
- assertBlobProbablyEqual(responseBlob, request2.responseBlob);
- completeAsync();
- });
- });
+ startAsync();
+ var url = '/testcases/test_file_1024.txt';
+ httpGetAsRequest(url, function(request) {
+ var store = getFreshStore();
+ var captureUrl = '/captured.txt';
+ var responseBlob = request.responseBlob;
+ if (isWince) {
+ assertError(
+ function() {store.captureBlob(responseBlob, captureUrl)},
+ 'captureBlob is not implemented',
+ 'captureBlob is not yet implemented on WinCE');
+ completeAsync();
+ return;
+ }
+ store.captureBlob(responseBlob, captureUrl);
+ httpGetAsRequest(captureUrl, function(request2) {
+ assertBlobProbablyEqual(responseBlob, request2.responseBlob);
+ completeAsync();
+ });
+ });
}
function testGoodManifest() {
