Hello aa,
I'd like you to do a code review. Please execute
g4 diff -c 8648893
or point your web browser to
http://mondrian/8648893
to review the following code:
Change 8648893 by [EMAIL PROTECTED] on 2008/10/19 18:54:44 *pending*
Test fix for when the version got bumped from 0.4 to 0.5.
PRESUBMIT=passed
R=aa
[EMAIL PROTECTED]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=8648893
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/factory_tests.js#4
edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 8648893
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8648893 by [EMAIL PROTECTED] on 2008/10/19 18:54:44 *pending*
Test fix for when the version got bumped from 0.4 to 0.5.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/factory_tests.js#4
edit
====
//depot/googleclient/gears/opensource/gears/test/testcases/factory_tests.js#4 -
/home/nigeltao/srcgears1/googleclient/gears/opensource/gears/test/testcases/factory_tests.js
====
# action=edit type=text
--- googleclient/gears/opensource/gears/test/testcases/factory_tests.js
2008-10-19 18:55:00.000000000 +1100
+++ googleclient/gears/opensource/gears/test/testcases/factory_tests.js
2008-10-19 18:53:59.000000000 +1100
@@ -29,7 +29,7 @@
var minor = versionComponents[1];
assertEqual(4, versionComponents.length);
assertEqual('0', major);
- assertEqual('4', minor);
+ assertEqual('5', minor);
}
function testCreateValidModules() {
