Hello aa,
I'd like you to do a code review. Please execute
g4 diff -c 8653247
or point your web browser to
http://mondrian/8653247
to review the following code:
Change 8653247 by [EMAIL PROTECTED] on 2008/10/20 18:46:26 *pending*
Added a test page for Gears Drag-and-Drop.
PRESUBMIT=passed
R=aa
[EMAIL PROTECTED]
DELTA=61 (61 added, 0 deleted, 0 changed)
OCL=8653247
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/manual/drag_and_drop.html#1 add
61 delta lines: 61 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 8653247
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8653247 by [EMAIL PROTECTED] on 2008/10/20 18:46:26 *pending*
Added a test page for Gears Drag-and-Drop.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/manual/drag_and_drop.html#1 add
====
//depot/googleclient/gears/opensource/gears/test/manual/drag_and_drop.html#1 -
/home/nigeltao/srcgears2/googleclient/gears/opensource/gears/test/manual/drag_and_drop.html
====
# action=add type=text
--- /dev/null 1970-01-01 10:00:00.000000000 +1000
+++ googleclient/gears/opensource/gears/test/manual/drag_and_drop.html
2008-10-20 18:44:46.000000000 +1100
@@ -0,0 +1,61 @@
+<html><head><title>Gears Drag and Drop</title></head>
+<body>
+<div id="dropZone" style="background-color: yellow; width:20em; height:15em">
+<ol>
+<li>Drag some files from the desktop.</li>
+<li>Drop them on this DIV.</li>
+<li>???</li>
+<li>Profit!</li>
+</ol>
+</div>
+<div id="dragEnterOutput"> </div>
+<div id="dragOverOutput"> </div>
+<div id="dragLeaveOutput"> </div>
+<div id="dropOutput"> </div>
+
+<script type="text/javascript" src="../../sdk/gears_init.js"></script>
+<script type="text/javascript">
+var dragEnterCount = 0;
+var dragOverCount = 0;
+var dragLeaveCount = 0;
+var dropCount = 0;
+var eventCount = 0;
+var desktop = google.gears.factory.create('beta.desktop');
+desktop.registerDropTarget(document.getElementById('dropZone'), {
+ 'ondragenter': function() {
+ dragEnterCount++;
+ eventCount++;
+ document.getElementById('dragEnterOutput').innerHTML =
+ 'Got <b>dragenter</b>: ' + dragEnterCount +
+ ' times, most recent sequence number is ' + eventCount;
+ },
+ 'ondragover': function() {
+ dragOverCount++;
+ eventCount++;
+ document.getElementById('dragOverOutput').innerHTML =
+ 'Got <b>dragover</b>: ' + dragOverCount +
+ ' times, most recent sequence number is ' + eventCount;
+ },
+ 'ondragleave': function() {
+ dragLeaveCount++;
+ eventCount++;
+ document.getElementById('dragLeaveOutput').innerHTML =
+ 'Got <b>dragleave</b>: ' + dragLeaveCount +
+ ' times, most recent sequence number is ' + eventCount;
+ },
+ 'ondrop': function(files) {
+ dropCount++;
+ eventCount++;
+ var s = 'Got <b>drop</b>: ' + dropCount +
+ ' times, most recent sequence number is ' + eventCount + '<hr/>';
+ for (i = 0; i < files.length; i++) {
+ var file = files[i];
+ s += '<b>' + file.name + '</b> has length <b>' +
+ file.blob.length + '</b>.<br/>';
+ }
+ document.getElementById('dropOutput').innerHTML = s;
+ }
+});
+</script>
+</body>
+</html>
