Hello nigeltao,
I'd like you to do a code review. Please execute
g4 diff -c 8655400
or point your web browser to
http://mondrian/8655400
to review the following code:
Change 8655400 by [EMAIL PROTECTED] on 2008/10/20 15:00:21 *pending*
Enables captureBlob for IE Mobile.
It looks like this was simply omitted from CL 6625340. Nigel, do you
know of anything I might be missing?
R=nigeltao
[EMAIL PROTECTED]
DELTA=15 (0 added, 15 deleted, 0 changed)
OCL=8655400
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/resource_store_module.cc#9
edit
...
//depot/googleclient/gears/opensource/gears/test/testcases/localserver_tests.js#7
edit
15 delta lines: 0 added, 15 deleted, 0 changed
Also consider running:
g4 lint -c 8655400
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8655400 by [EMAIL PROTECTED] on 2008/10/20 15:00:21 *pending*
Enables captureBlob for IE Mobile.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/resource_store_module.cc#9
edit
...
//depot/googleclient/gears/opensource/gears/test/testcases/localserver_tests.js#7
edit
====
//depot/googleclient/gears/opensource/gears/localserver/resource_store_module.cc#9
-
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/localserver/resource_store_module.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/localserver/resource_store_module.cc
2008-10-20 15:24:02.000000000 +0100
+++ googleclient/gears/opensource/gears/localserver/resource_store_module.cc
2008-10-20 15:05:00.000000000 +0100
@@ -434,10 +434,6 @@
// CaptureBlob
//------------------------------------------------------------------------------
void GearsResourceStore::CaptureBlob(JsCallContext *context) {
-#ifdef OS_WINCE
- context->SetException(STRING16(L"captureBlob is not implemented."));
-#else
-
ModuleImplBaseClass *other_module = NULL;
std::string16 url;
JsArgument argv[] = {
@@ -469,7 +465,6 @@
context->SetException(STRING16(L"The blob could not be captured."));
return;
}
-#endif
}
//------------------------------------------------------------------------------
====
//depot/googleclient/gears/opensource/gears/test/testcases/localserver_tests.js#7
-
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/test/testcases/localserver_tests.js
====
# action=edit type=text
--- googleclient/gears/opensource/gears/test/testcases/localserver_tests.js
2008-10-20 15:24:02.000000000 +0100
+++ googleclient/gears/opensource/gears/test/testcases/localserver_tests.js
2008-10-20 14:58:20.000000000 +0100
@@ -328,16 +328,6 @@
var store = getFreshStore();
var captureUrl = '/captured.txt';
var responseBlob = request.responseBlob;
- if (isWince) {
- assertError(
- function() {
- store.captureBlob(responseBlob, captureUrl)
- },
- 'captureBlob is not implemented',
- 'captureBlob is not yet implemented on WinCE');
- completeAsync();
- return;
- }
store.captureBlob(responseBlob, captureUrl);
httpGetAsRequest(captureUrl, function(request2) {
assertBlobProbablyEqual(responseBlob, request2.responseBlob);
